Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs/issues with the message queue #124

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

JFreegman
Copy link
Member

@JFreegman JFreegman commented Nov 12, 2020

  • It's no longer possible for messages to be sent out of order
  • Check if logger is enabled before doing pointless API calls
  • Fix linked list bug (a part of the code that almost never executes)

This change is Reviewable

@JFreegman JFreegman added bug Bug fix for the user, not a fix to a build script cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature. labels Nov 12, 2020
@JFreegman JFreegman added this to the 0.8.x milestone Nov 12, 2020
- It's no longer possible for messages to be sent out of order
- Check if logger is enabled before doing pointless API calls
- Fix linked list bug (a part of the code almost never executes)
@JFreegman JFreegman merged commit 15b7a30 into TokTok:master Nov 12, 2020
@JFreegman JFreegman deleted the message_queue_fix branch November 12, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix for the user, not a fix to a build script cleanup Internal code cleanup, possibly affecting semantics, e.g. deleting a deprecated feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants